From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Marinescu Paul dan <pauldan.marinescu@epfl.ch>,
Junio C Hamano <gitster@pobox.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Running commands in wrong environment
Date: Fri, 04 Dec 2009 09:16:45 -0800 [thread overview]
Message-ID: <7vr5raslqa.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20091204104441.GD27495@coredump.intra.peff.net> (Jeff King's message of "Fri\, 4 Dec 2009 05\:44\:41 -0500")
Jeff King <peff@peff.net> writes:
> But the consequences, as you mention, could include data loss, which
> argues for being on the safe side. In that case, we would probably want
> an "xsetenv" to die() if we fail to avoid cluttering the code
> everywhere.
>
> I dunno. If we're going to do it, it is probably maint-worthy. Junio?
My gut feeling is xsetenv/xputenv would be sufficient. I do not think we
make any setenv/putenv that we do not care about failing, perhaps other
than the "if LESS is not there set it to this default value, as it would
give users nicer experience if they use 'less'."
next prev parent reply other threads:[~2009-12-04 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 19:19 Running commands in wrong environment Marinescu Paul dan
2009-12-04 10:44 ` Jeff King
2009-12-04 17:16 ` Junio C Hamano [this message]
2009-12-06 14:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr5raslqa.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pauldan.marinescu@epfl.ch \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).