From: Junio C Hamano <gitster@pobox.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Jeff King <peff@peff.net>, Johan Herland <johan@herland.net>,
Daniel Barkalow <barkalow@iabervon.org>,
git@vger.kernel.org
Subject: Re: [PATCH] tests: handle NO_PYTHON setting
Date: Mon, 30 Nov 2009 00:49:36 -0800 [thread overview]
Message-ID: <7vr5rgv1lr.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <fabb9a1e0911300035o532153b7qdc2ecd768200ce09@mail.gmail.com> (Sverre Rabbelier's message of "Mon\, 30 Nov 2009 09\:35\:22 +0100")
Sverre Rabbelier <srabbelier@gmail.com> writes:
> On Mon, Nov 30, 2009 at 09:28, Junio C Hamano <gitster@pobox.com> wrote:
>> Sverre Rabbelier <srabbelier@gmail.com> writes:
>>> I don't think that's true, git.git currently does not have such a
>>> structure (everything is just dumped in the root directory). The only
>>> reason git_remote_helpers exists is to make it easier to create a
>>> python egg out of it and install that.
>>
>> If that is the case, shouldn't each of the helper written in Python need
>> to have a separate directory, not just a single git_remote_helpers
>> directory shared among them?
>
> I don't understand why that would be needed? The reason we added a
> single git_remote_helpers directory is because we wanted to share
> common code, having a single python package makes that easy.
Sorry, I don't understand that. With that reasoning, isn't having a
single git package, be it python or not, even easier? Why would anybody
want a separate egg that includes everything that _happen_ to be written
in Python in the first place? It doesn't make sense at all from packaging
point of view to me.
A separate egg per remote-helper that you can pick and choose which ones
to install and which ones to leave out would make perfect sense, exactly
the same way that distros already split git into "git-core", "git-svn",
etc., though. Your "git-hg" may consist of a single egg and perhaps some
other supporting code, and people who want to convert away from legacy Hg
repository may want to install it, but it is entirely up to them if they
also want to install "git-cvs" that is implemented as a remote-helper that
happens to be written in Python, no?
next prev parent reply other threads:[~2009-11-30 8:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 7:52 [PATCH] tests: handle NO_PYTHON setting Jeff King
2009-11-30 7:55 ` Sverre Rabbelier
2009-11-30 7:59 ` Jeff King
2009-11-30 8:04 ` Sverre Rabbelier
2009-11-30 8:05 ` Jeff King
2009-11-30 8:28 ` Junio C Hamano
2009-11-30 8:35 ` Sverre Rabbelier
2009-11-30 8:49 ` Junio C Hamano [this message]
2009-11-30 9:56 ` Sverre Rabbelier
2009-11-30 10:59 ` Johan Herland
2009-11-30 17:27 ` Junio C Hamano
2009-11-30 18:01 ` Johan Herland
2009-11-30 18:07 ` Brandon Casey
2009-11-30 20:54 ` Jeff King
2009-11-30 21:17 ` Brandon Casey
2009-11-30 22:31 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr5rgv1lr.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=peff@peff.net \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).