From: Junio C Hamano <gitster@pobox.com>
To: Matt Kraai <kraai@ftbfs.org>
Cc: git@vger.kernel.org
Subject: Re: Extra checks for PERL_PATH and SHELL_PATH?
Date: Mon, 19 Oct 2009 23:36:26 -0700 [thread overview]
Message-ID: <7vr5syshat.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20091020035051.GA3237@ftbfs.org> (Matt Kraai's message of "Mon\, 19 Oct 2009 20\:50\:51 -0700")
Matt Kraai <kraai@ftbfs.org> writes:
> The top-level Makefile currently contains
>
>> ifndef SHELL_PATH
>> SHELL_PATH = /bin/sh
>> endif
>> ifndef PERL_PATH
>> PERL_PATH = /usr/bin/perl
>> endif
>
> The checks are only necessary if these variables need to be overridden
> by environment variables, not just via the make command line. Is this
> the case?
It may not have been the original intention, but the above would mean that
some people may have learned to run "SHELL_PATH=/bin/ksh make" and
changing it would break things for them, no?
I do not think changing them is bad per-se, but we would need to add extra
warnings in the release note to explain this change, that's all. This
would only affect people who build from the source (including distro
people) so it is not really a big deal.
next prev parent reply other threads:[~2009-10-20 6:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 3:50 Extra checks for PERL_PATH and SHELL_PATH? Matt Kraai
2009-10-20 6:36 ` Junio C Hamano [this message]
2009-10-20 9:06 ` [PATCH] Makefile: set PERL_PATH and SHELL_PATH unconditionally Matt Kraai
2009-10-20 16:18 ` Junio C Hamano
2009-10-20 16:33 ` Matt Kraai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr5syshat.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kraai@ftbfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).