From: Junio C Hamano <gitster@pobox.com>
To: markus.heidelberg@web.de
Cc: Samuel Bronson <naesten@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] Makefile: add commented out 's for Emacs here, too
Date: Sat, 30 May 2009 12:07:30 -0700 [thread overview]
Message-ID: <7vr5y6z9xp.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 200905301505.38016.markus.heidelberg@web.de
Markus Heidelberg <markus.heidelberg@web.de> writes:
>> +# unconfuse Emacs: '
>> +
>> +# The above comment is in case there is an odd number of _SQ
>> +# definitions above, since they seem to confuse Emacs. If there is an
>> +# even number of such definitions, it does no harm, since emacs
>> +# doesn't recognize string delimiters inside recognized comments.
> ...
> I think this is way too much comment and would prefer none at all. I
> also would remove the global 4-line comment.
I personally do not like contaminating our source files with this kind of
magic crufts just to please broken tools, be they emacs or vim. I would
hate them even more if they are not clearly commented why they exist for
two reasons.
(1) without clear instructions ("odd number of ..." is not quite enough),
people who do *not* use broken tools cannot keep them up-to-date when
they make modifications;
(2) when broken tools are finally fixed, nobody would remember why the
magic crufts exist, and they will end up staying in the source for a
long time.
next prev parent reply other threads:[~2009-05-30 19:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 22:07 [PATCH 1/3] Documentation/Makefile: add a commented-out ' to unconfuse Emacs Samuel Bronson
2009-05-25 22:07 ` [PATCH 2/3] Makefile: Add "make help" telling users to read INSTALL and Makefile Samuel Bronson
2009-05-25 22:07 ` [PATCH 3/3] Makefile: add commented out 's for Emacs here, too Samuel Bronson
2009-05-30 13:05 ` Markus Heidelberg
2009-05-30 18:37 ` Samuel Bronson
2009-05-30 19:07 ` Junio C Hamano [this message]
2009-05-30 22:01 ` Markus Heidelberg
2013-12-19 23:37 ` Samuel Bronson
2013-12-19 23:52 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr5y6z9xp.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=markus.heidelberg@web.de \
--cc=naesten@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).