From: Junio C Hamano <gitster@pobox.com>
To: Daniel Cordero <theappleman@gmail.com>
Cc: Nanako Shiraishi <nanako3@lavabit.com>, git@vger.kernel.org
Subject: Re: [PATCH] builtin-checkout: Don't tell user that HEAD has moved before it has
Date: Sat, 16 May 2009 12:57:44 -0700 [thread overview]
Message-ID: <7vr5yolt1j.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20090516175444.GA1000@cumin.applehq.eu
Daniel Cordero <theappleman@gmail.com> writes:
> Previously, checkout would tell the user this message before moving HEAD,
> without regard to whether the upcoming move will result in success.
> If the move failed, this causes confusion.
>
> Show the message after the move, unless the move failed.
>
> Signed-off-by: Daniel Cordero <theappleman@gmail.com>
Thanks; the patch looks obviously good. Can we have tests?
next prev parent reply other threads:[~2009-05-16 19:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-16 10:25 [buglet] misleading error message from git checkout Nanako Shiraishi
2009-05-16 17:54 ` [PATCH] builtin-checkout: Don't tell user that HEAD has moved before it has Daniel Cordero
2009-05-16 19:57 ` Junio C Hamano [this message]
2009-05-17 2:43 ` [PATCH] test: checkout shouldn't say that HEAD has moved if it didn't Nanako Shiraishi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr5yolt1j.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nanako3@lavabit.com \
--cc=theappleman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).