git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "George Spelvin" <linux@horizon.com>
Cc: git@vger.kernel.org
Subject: Re: fatal: git grep: cannot generate relative filenames containing '..'
Date: Thu, 15 Jan 2009 17:52:56 -0800	[thread overview]
Message-ID: <7vr634ow3r.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090115222905.8157.qmail@science.horizon.com> (George Spelvin's message of "Thu, 15 Jan 2009 17:29:05 -0500")

"George Spelvin" <linux@horizon.com> writes:

> Could someone fix this some day?

As far as I know you are the first to ask for this, so perhaps people never
considered this was something to "fix"....

> "git grep <pattern> ../include"
> is something I find myself wanting quite frequently, and it's a fresh
> annoyance every time I type it to discover that it still doesn't work.
>
> While you're at it, an option to search the entire git tree rather than
> the current subdirectory would also be useful.  I was thinking about
> a flag like -r (for "root"),...

... but

    $ grep -r foo ..

will look for foo anywhere below one level up from your current directory,
and I think it may be a reasonable enhancement to teach:

    $ git grep foo ..

to do the same.  Patches welcome ;-).

By the way, congratulations for getting a name.  Can we fix one entry in
our .mailmap file?

  parent reply	other threads:[~2009-01-16  1:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15 22:29 fatal: git grep: cannot generate relative filenames containing '..' George Spelvin
2009-01-15 23:04 ` Markus Heidelberg
2009-01-16  1:52 ` Junio C Hamano [this message]
2009-01-16 21:30   ` Jon Loeliger
2009-01-17  2:21   ` Hannu Koivisto
2009-01-18 16:58     ` George Spelvin
2009-01-16  2:07 ` Johannes Schindelin
2009-01-16  2:12   ` Junio C Hamano
2009-01-16  3:27     ` George Spelvin
2009-01-16  4:24       ` George Spelvin
2009-01-16 11:41       ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr634ow3r.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=linux@horizon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).