From: Junio C Hamano <gitster@pobox.com>
To: Pieter de Bie <pdebie@ai.rug.nl>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Git Mailinglist <git@vger.kernel.org>
Subject: Re: [PATCH v3] builtin-fast-export: Add importing and exporting of revision marks
Date: Wed, 11 Jun 2008 14:43:06 -0700 [thread overview]
Message-ID: <7vr6b3bqc5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1213183024-60013-1-git-send-email-pdebie@ai.rug.nl> (Pieter de Bie's message of "Wed, 11 Jun 2008 13:17:04 +0200")
Pieter de Bie <pdebie@ai.rug.nl> writes:
> This adds the --import-marks and --export-marks to fast-export. These import
> and export the marks used to for all revisions exported in a similar fashion
> to what fast-import does. The format is the same as fast-import, so you can
> create a bidirectional importer / exporter by using the same marks file on
> both sides.
Heh, I've long queued a fixed-up version in 'pu' as 4ba0575
(builtin-fast-export: Add importing and exporting of revision marks,
2008-06-05).
I think renaming the "mark_object" to "mark_next_object" makes quite a lot
of sense, and I do not have any preference between mark2deco vs mark_to_ptr
nor between a macro vs a static inline function for something small like
these.
You still use export_filename and import_filename uninitialized in
cmd_fast_export() and breaks everybody who does not use export-marks
option. Has this patch (and the previous one I fixed up before queuing it
in 'pu') ever been tested?
next prev parent reply other threads:[~2008-06-11 21:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 20:55 [PATCH] builtin-fast-export: Add importing and exporting of revision marks Pieter de Bie
2008-06-05 0:00 ` Johannes Schindelin
2008-06-05 10:46 ` Pieter de Bie
2008-06-05 10:52 ` [PATCH v2] " Pieter de Bie
2008-06-05 13:35 ` Johannes Schindelin
2008-06-06 23:09 ` Junio C Hamano
2008-06-07 13:06 ` Pieter de Bie
2008-06-07 15:19 ` Johannes Schindelin
2008-06-07 16:37 ` Junio C Hamano
2008-06-11 19:45 ` Johannes Schindelin
2008-06-07 13:25 ` [PATCH] Documentation/fast-export: Document --import-marks and --export-marks options Pieter de Bie
2008-06-07 15:20 ` Johannes Schindelin
2008-06-10 6:47 ` Junio C Hamano
2008-06-11 11:17 ` [PATCH v3] builtin-fast-export: Add importing and exporting of revision marks Pieter de Bie
2008-06-11 11:24 ` Pieter de Bie
2008-06-11 18:45 ` Johannes Schindelin
2008-06-11 21:43 ` Junio C Hamano [this message]
2008-06-05 13:31 ` [PATCH] " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6b3bqc5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pdebie@ai.rug.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).