From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 04/16] grep portability fix: don't use "-e" or "-q" Date: Wed, 12 Mar 2008 15:10:53 -0700 Message-ID: <7vr6ef4mqa.fsf@gitster.siamese.dyndns.org> References: <20080312213217.GE26286@coredump.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Whit Armstrong , git@vger.kernel.org To: Jeff King X-From: git-owner@vger.kernel.org Wed Mar 12 23:12:02 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JZZAr-0005o5-AS for gcvg-git-2@gmane.org; Wed, 12 Mar 2008 23:11:49 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752437AbYCLWLK (ORCPT ); Wed, 12 Mar 2008 18:11:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751624AbYCLWLJ (ORCPT ); Wed, 12 Mar 2008 18:11:09 -0400 Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:34343 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbYCLWLI (ORCPT ); Wed, 12 Mar 2008 18:11:08 -0400 Received: from localhost.localdomain (localhost [127.0.0.1]) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 053942CB8; Wed, 12 Mar 2008 18:11:07 -0400 (EDT) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id 69D262CB7; Wed, 12 Mar 2008 18:11:03 -0400 (EDT) In-Reply-To: <20080312213217.GE26286@coredump.intra.peff.net> (Jeff King's message of "Wed, 12 Mar 2008 17:32:17 -0400") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Jeff King writes: > System V versions of grep (such as Solaris /usr/bin/grep) > don't understand either of these options. git's usage of It might be fair for other System V people to qualify the above statement with "Historic System V" (personally I felt that Solaris without xpg4 was unusable, and I wish you luck tackling it). More seriously, you would need to disable "when grepping work-tree, running the native grep is faster and just as capable" optimization in builtin-grep.c::grep_cache(). Treat these problematic System V platforms as if they are not __unix__. I am surprised that you did not have issues with "tail -n$number". Historic way to spell it was "tail -$number" wasn't it?