From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] git-help: add "help.format" config variable.
Date: Wed, 12 Dec 2007 01:04:57 -0800 [thread overview]
Message-ID: <7vr6hs8erq.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071212063320.3cbb1698.chriscool@tuxfamily.org> (Christian Couder's message of "Wed, 12 Dec 2007 06:33:20 +0100")
Christian Couder <chriscool@tuxfamily.org> writes:
> diff --git a/git.c b/git.c
> index 4f9876e..d46b63d 100644
> --- a/git.c
> +++ b/git.c
> @@ -324,7 +324,7 @@ static void handle_internal_command(int argc, const char **argv)
> { "gc", cmd_gc, RUN_SETUP },
> { "get-tar-commit-id", cmd_get_tar_commit_id },
> { "grep", cmd_grep, RUN_SETUP | USE_PAGER },
> - { "help", cmd_help },
> + { "help", cmd_help, RUN_SETUP },
> #ifndef NO_CURL
> { "http-fetch", cmd_http_fetch, RUN_SETUP },
> #endif
It would be _NICE_ if we read configuration when we are in a git
repository, but I am afraid this change is unnice -- the users used to
be able to say "git help" from anywhere didn't they? Now they will get
"Not a git repository". It needs to do an optional repository
discovery, not a mandatory one RUN_SETUP causes.
next prev parent reply other threads:[~2007-12-12 9:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 5:33 [PATCH 1/2] git-help: add "help.format" config variable Christian Couder
2007-12-12 9:04 ` Junio C Hamano [this message]
2007-12-13 1:41 ` Junio C Hamano
2007-12-15 4:57 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6hs8erq.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).