From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, krh@redhat.com, gitster@pobox.com
Subject: Re: [PATCH] builtin-commit: fix --signoff
Date: Sat, 10 Nov 2007 01:06:28 -0800 [thread overview]
Message-ID: <7vr6iyo4ff.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0711100548071.4362@racer.site> (Johannes Schindelin's message of "Sat, 10 Nov 2007 05:49:14 +0000 (GMT)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> if (signoff) {
> ...
> + strbuf_init(&sob, 0);
> + strbuf_addstr(&sob, sign_off_header);
> + strbuf_addstr(&sob, git_committer_info(1));
> + p = strrchr(sob.buf, '>');
> + if (p)
> + strbuf_setlen(&sob, p + 1 - sob.buf);
> + strbuf_addch(&sob, '\n');
> +
> + for (i = sb.len - 1; i > 0 && sb.buf[i - 1] != '\n'; i--)
> + ; /* do nothing */
> + if (prefixcmp(sb.buf + i, sob.buf))
> + strbuf_addbuf(&sb, &sob);
> }
At this point doesn't this leak sob.buf?
next prev parent reply other threads:[~2007-11-10 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 5:49 [PATCH] builtin-commit: fix --signoff Johannes Schindelin
2007-11-10 9:06 ` Junio C Hamano [this message]
2007-11-10 13:16 ` Pierre Habouzit
2007-11-10 13:47 ` Johannes Schindelin
2007-11-10 15:58 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6iyo4ff.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=krh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).