From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-fetch: avoid local fetching from alternate (again)
Date: Wed, 07 Nov 2007 12:32:40 -0800 [thread overview]
Message-ID: <7vr6j1bxuf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <7vsl3iefoj.fsf@gitster.siamese.dyndns.org> (Junio C. Hamano's message of "Tue, 06 Nov 2007 22:24:28 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Well spotted. It would be a good idea to commit the big comment
> from contrib/examples/git-fetch.sh to fetch_local_nocopy()
> function, which would have made us realize that the patch does
> not refrain from applying this optimization even when shallow
> is in effect. But I think that is actually a good change.
I take this back. This regresses badly.
Why?
Because the optimization is useless when we are trying to deepen
the shallow history. When you are trying to deepen a shallow
history and the tips of remotes haven't moved since you fetched
from there the last time, you have everything near the tip, and
becuse your history is shallow, your ancestry chain is
cauterized to make it appear that the history is complete. The
rev-list reachability test would not fail as we expect.
The breakage can be seen with t5500.
next prev parent reply other threads:[~2007-11-07 20:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 2:41 [PATCH] git-fetch: avoid local fetching from alternate (again) Shawn O. Pearce
2007-11-07 6:24 ` Junio C Hamano
2007-11-07 7:45 ` Junio C Hamano
2007-11-07 20:32 ` Junio C Hamano [this message]
2007-11-08 7:35 ` Shawn O. Pearce
2007-11-08 8:04 ` Shawn O. Pearce
2007-11-07 8:12 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6j1bxuf.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).