From: Junio C Hamano <gitster@pobox.com>
To: Brandon Casey <casey@nrlssc.navy.mil>
Cc: James Bowes <jbowes@dangerouslyinc.com>, git@vger.kernel.org
Subject: Re: [PATCH] gc: use parse_options
Date: Mon, 05 Nov 2007 16:37:08 -0800 [thread overview]
Message-ID: <7vr6j4ky4r.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <472FA26E.4060706@nrlssc.navy.mil> (Brandon Casey's message of "Mon, 05 Nov 2007 17:08:30 -0600")
Brandon Casey <casey@nrlssc.navy.mil> writes:
> Junio C Hamano wrote:
>> James Bowes <jbowes@dangerouslyinc.com> writes:
>>
>>> + struct option builtin_gc_options[] = {
>>> + OPT_BOOLEAN(0, "prune", &prune, "prune unused objects"),
>>
>> I would write "unreferenced loose" instead of "unused" here...
>
> It is not just "loose" objects here, but also unreferenced objects in packs,
> since the "-a" option to repack is now only used when --prune is specified.
> Without --prune, "-A" is supplied to repack instead.
>
> So maybe the message should just be "prune unreferenced objects"
Fair enough, will do.
prev parent reply other threads:[~2007-11-06 0:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 0:28 [PATCH] gc: use parse_options James Bowes
2007-11-02 0:49 ` Junio C Hamano
2007-11-02 1:02 ` James Bowes
2007-11-02 8:32 ` Pierre Habouzit
2007-11-05 23:08 ` Brandon Casey
2007-11-06 0:37 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6j4ky4r.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=jbowes@dangerouslyinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).