git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Simon Sasburg" <simon.sasburg@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] Make git-mailinfo strip whitespace from the start of the mail file.
Date: Thu, 01 Nov 2007 15:26:34 -0700	[thread overview]
Message-ID: <7vr6j98uw5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <981e6de60711011441n5bef772cuda381c539c0a2603@mail.gmail.com> (Simon Sasburg's message of "Thu, 1 Nov 2007 22:41:01 +0100")

"Simon Sasburg" <simon.sasburg@gmail.com> writes:

>> Just to help me understand why this change is needed...
>>
>> Are you using mailinfo directly without splitting with mailsplit
>> first?
>
> Well, when using gmail's web interface, when reading a mail, there is
> this option to show the raw mail text (headers+body) with the 'show
> original' option.
>
> If you do 'save as..' in your browser to save what you get with that,
> and try to do git-am on that file, it fails because it starts with
> some whitespace.
>
> With this patch git-am works on these files.
>
> So, i'm not using mailsplit or any other mail tools at all, just my
> browser and git.

Ah, I meant "git-mailsplit", which is the command internally run
by "git-am" to preprocess the file and to split it into
individual mail pieces to be fed to "git-mailinfo".

That may suggest the change is better done in git-mailsplit not
git-mailinfo.

Or perhaps both.

  reply	other threads:[~2007-11-01 22:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-01 21:05 [PATCH] Make git-mailinfo strip whitespace from the start of the mail file Simon Sasburg
2007-11-01 21:33 ` Junio C Hamano
2007-11-01 21:41   ` Simon Sasburg
2007-11-01 22:26     ` Junio C Hamano [this message]
2007-11-01 22:57       ` [PATCH] Make git-mailsplit strip whitespace from the start of the mailbox file Simon Sasburg
2007-11-02  8:53 ` [PATCH] Make git-mailinfo strip whitespace from the start of the mail file Junio C Hamano
2007-11-04 13:32   ` [PATCH] Make git-mailsplit strip whitespace from the start of the mailbox file Simon Sasburg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr6j98uw5.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=simon.sasburg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).