From: Junio C Hamano <gitster@pobox.com>
To: Dan McGee <dpmcgee@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] rebase: standardize on $() for command substitution
Date: Wed, 31 Oct 2007 22:16:31 -0700 [thread overview]
Message-ID: <7vr6jaczps.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1193892608-31322-1-git-send-email-dpmcgee@gmail.com> (Dan McGee's message of "Wed, 31 Oct 2007 23:50:08 -0500")
Dan McGee <dpmcgee@gmail.com> writes:
> Commit 889a50e909dba5f4416049afc5eeae601fe133bc changed several `` to $()
> format for command substitution, so we should standardize on one format
> for clarity.
> ...
> @@ -203,7 +203,7 @@ do
> -s|--s|--st|--str|--stra|--strat|--strate|--strateg|--strategy)
> case "$#,$1" in
> *,*=*)
> - strategy=`expr "z$1" : 'z-[^=]*=\(.*\)'` ;;
> + strategy=$(expr "z$1" : 'z-[^=]*=\(.*\)'` ;)
> 1,*)
> usage ;;
> *)
The patch might have meant well, but it is a rather unnecessary
code churn without fixing anything and introducing a bug X-<.
next prev parent reply other threads:[~2007-11-01 5:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-01 4:50 [PATCH] rebase: standardize on $() for command substitution Dan McGee
2007-11-01 5:16 ` Junio C Hamano [this message]
2007-11-01 5:27 ` Dan McGee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6jaczps.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=dpmcgee@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).