git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix git-remote for ActiveState Perl
Date: Wed, 22 Aug 2007 13:19:24 -0700	[thread overview]
Message-ID: <7vr6lviapf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20070822161307.GA3528@steel.home> (Alex Riesen's message of "Wed, 22 Aug 2007 18:13:07 +0200")

Alex Riesen <raa.lkml@gmail.com> writes:

> For reason unknown a package in ActiveState Perl 5.8.7 must implement
> READLINE method differently for scalar and array context. The code
> tested to work for more sane and recent version of perl (5.8.8 shipped
> with Ubuntu), so maybe it was always a requirement.

Well spotted.

Unfortunately, the manual perltie.pod is very sketchy on this
issue, and only says:

    This method will be called when the handle is read from via <HANDLE>.
    The method should return undef when there is no more data.

The default implementation in Tie::StdHandle (Tie/Handle.pm)
does agree with you by doing this:

    sub READLINE { my $fh = $_[0]; <$fh> }

So I am fairly confident that your patch is the right fix.

Interestingly, CPAN::Tarzip::READLINE (CPAN.pm) gets it wrong ;-)
and caters only to calls in scalar context if I am reading the
code correctly.

Thanks.  Will apply.

      reply	other threads:[~2007-08-22 20:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-22 16:13 [PATCH] Fix git-remote for ActiveState Perl Alex Riesen
2007-08-22 20:19 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr6lviapf.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).