From: Junio C Hamano <junkio@cox.net>
To: Lars Hjemli <hjemli@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin-branch: be prepared for ref-logging
Date: Sat, 03 Feb 2007 11:50:05 -0800 [thread overview]
Message-ID: <7vr6t73tsi.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11705277471962-git-send-email-hjemli@gmail.com> (Lars Hjemli's message of "Sat, 3 Feb 2007 19:35:47 +0100")
Lars Hjemli <hjemli@gmail.com> writes:
> The test for reflog parameter to create_branch() should also have tested
> for log_all_ref_updates. But there is no good reason not to prepare a
> reflog message, so lets just do it.
>
> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> ---
>
> Sorry, the previous patch was obviously no good, since it didn't honour
> the case where (reflog==1 && log_all_ref_updates==0)
Ah, I did not see your fix-up patch before I sent out my
comments.
Funny thing is that I thought I fixed this already, but
apparently I didn't. It could have been one of my "fixing in
working tree, sending out a patch to the list for comments and
then forgetting to apply it". Maybe not.
In any case, thanks for the fix.
next prev parent reply other threads:[~2007-02-03 19:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-03 16:49 [PATCH] fix use of sometimes uninitialized variable 'msg' Michael Coleman
2007-02-03 16:49 ` [PATCH] fix uninitialized use of msg buffer Michael Coleman
2007-02-03 18:17 ` [PATCH] builtin-branch: be prepared for ref-logging Lars Hjemli
2007-02-03 18:55 ` Junio C Hamano
2007-02-03 18:35 ` Lars Hjemli
2007-02-03 19:50 ` Junio C Hamano [this message]
2007-02-03 20:38 ` Lars Hjemli
2007-02-03 20:54 ` Junio C Hamano
2007-02-03 21:20 ` Lars Hjemli
2007-02-03 23:21 ` Junio C Hamano
2007-02-03 17:05 ` [PATCH] fix use of sometimes uninitialized variable 'msg' Mike Coleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6t73tsi.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=hjemli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).