From: Junio C Hamano <junkio@cox.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Bill Lear <rael@zopyra.com>, git@vger.kernel.org
Subject: Re: Meaning of "fatal: protocol error: bad line length character"?
Date: Mon, 22 Jan 2007 12:15:13 -0800 [thread overview]
Message-ID: <7vr6tmstri.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070120213738.GA8973@spearce.org> (Shawn O. Pearce's message of "Sat, 20 Jan 2007 16:37:38 -0500")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> Junio C Hamano <junkio@cox.net> wrote:
>> Funny thing is, at least in recent enough git, I think we set up
>> redirection to force output from hook scripts to stderr, but I
>> do not remember when it happened. Let's see...
>>
>> ...goes and looks...
>>
>> That was supposed to have been fixed with commit cd83c74c (Dec
>> 30, 2006), but this indicates the fix is not working at all when
>> your login shell is tcsh.
>
> Don't tell us tcsh is doing something ugly like opening the tty for
> stdout/stderr instead of using the ones it inherited from its parent.
> 'cause that's just useless!
It turns out that this was a stupidity on the part of the tester
(i.e. me).
I let the distro to install a version of git in /usr/bin/, and
my .cshrc is not set up to add /home/junio/git-active/bin (I
have $HOME/git-{master,next,pu,maint}/bin and git-active is a
symlink to git-master right now -- usually it points at
git-next), for non-interactive session like invoking
receive-pack. But my bash startup does. The breakage I was
seeing was _NOT_ because of differences between tcsh and bash,
but because the fix is fairly recent.
I forced the master version of receive-pack to be used on the
remote side using --receive-pack command line parameter, and
things seem to work fine with either tcsh or bash.
So, no, there might be valid reasons to hate tcsh, but this is
not one of them.
next prev parent reply other threads:[~2007-01-22 20:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-20 12:04 Meaning of "fatal: protocol error: bad line length character"? Bill Lear
2007-01-20 19:24 ` Junio C Hamano
2007-01-20 19:33 ` Junio C Hamano
2007-01-20 19:54 ` Bill Lear
2007-01-20 20:07 ` Jakub Narebski
2007-01-20 20:20 ` Junio C Hamano
2007-01-20 20:42 ` Junio C Hamano
2007-01-20 21:37 ` Shawn O. Pearce
2007-01-22 20:15 ` Junio C Hamano [this message]
2007-01-22 18:58 ` Bill Lear
2007-01-22 19:45 ` Junio C Hamano
2007-01-22 19:55 ` Bill Lear
2007-01-22 22:16 ` Bill Lear
2007-01-22 22:33 ` Junio C Hamano
2007-01-23 0:14 ` Han-Wen Nienhuys
2007-01-23 0:44 ` Junio C Hamano
2007-01-23 0:53 ` Han-Wen Nienhuys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6tmstri.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=rael@zopyra.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).