From: Junio C Hamano <junkio@cox.net>
To: Pavel Roskin <proski@gnu.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] off-by-one bugs found by valgrind
Date: Wed, 21 Dec 2005 12:59:14 -0800 [thread overview]
Message-ID: <7vr7865fq5.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <1135197348.3046.7.camel@dv> (Pavel Roskin's message of "Wed, 21 Dec 2005 15:35:48 -0500")
Pavel Roskin <proski@gnu.org> writes:
> Insufficient memory is allocated in index-pack.c to hold the *.idx name.
> One more byte should be allocated to hold the terminating 0.
Thanks.
> quote_c_style_counted() in quote.c uses a dangerous construct, when a
> variable is incremented once and used twice in the same expression.
Sorry, I do not follow you. Isn't && a sequence point?
> - for (sp = name; (ch = *sp++) && (sp - name) <= namelen; ) {
> -
> + for (sp = name; sp < name + namelen; sp++) {
next prev parent reply other threads:[~2005-12-21 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-21 20:35 [PATCH] off-by-one bugs found by valgrind Pavel Roskin
2005-12-21 20:59 ` Junio C Hamano [this message]
2005-12-21 21:17 ` H. Peter Anvin
2005-12-21 21:47 ` Pavel Roskin
2005-12-22 0:27 ` Horst von Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr7865fq5.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).