From: Junio C Hamano <junkio@cox.net>
To: git@vger.kernel.org
Subject: Re: [PATCH] Clean up file descriptors when calling hooks.
Date: Wed, 07 Dec 2005 19:29:47 -0800 [thread overview]
Message-ID: <7vr78omfkk.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20051208032428.8591.qmail@science.horizon.com> (linux@horizon.com's message of "7 Dec 2005 22:24:28 -0500")
linux@horizon.com writes:
> E.g. imagine if I ran gcc -c file.c, and it assigned file.c to fd 0,
> file.h to fd1, and file.o to fd 2. Then wants to print a warning
> message... right into the middle of the binary. (Oversimplified
> example, because gcc is actually several separate programs, but
> hopefully you get the idea.)
>
> It's just safer to leave those fds open to a null device.
Overdangerous example. Do people realize hooks run without any
locking?
next prev parent reply other threads:[~2005-12-08 3:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 3:24 [PATCH] Clean up file descriptors when calling hooks linux
2005-12-08 3:29 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-12-08 2:04 Daniel Barkalow
2005-12-08 2:25 ` Junio C Hamano
2005-12-08 5:33 ` Daniel Barkalow
2005-12-08 5:40 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr78omfkk.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).