From: Junio C Hamano <junkio@cox.net>
To: merlyn@stonehenge.com (Randal L. Schwartz)
Cc: git@vger.kernel.org
Subject: Re: git 565ebbf79f61873042c22a7126d002c104e056f4 broken on OpenBSD
Date: Wed, 26 Oct 2005 13:08:12 -0700 [thread overview]
Message-ID: <7vr7a8ca8j.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <86mzkwdsef.fsf@blue.stonehenge.com> (Randal L. Schwartz's message of "26 Oct 2005 11:50:32 -0700")
merlyn@stonehenge.com (Randal L. Schwartz) writes:
> It's cleaner to test for the ones that work, building up an OR'ed expression.
You are right. In this case the only thing we care about is if
it failed because of EEXIST, so checking that and trying to fall
back on rename() otherwise seems cleanest, as Linus and others
suggests.
I swallowed Linus version. Thanks for reporting (and also ctype
fix the other day).
next prev parent reply other threads:[~2005-10-26 20:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-26 14:11 git 565ebbf79f61873042c22a7126d002c104e056f4 broken on OpenBSD Randal L. Schwartz
2005-10-26 14:24 ` Randal L. Schwartz
2005-10-26 15:09 ` Johannes Schindelin
2005-10-26 15:10 ` Randal L. Schwartz
2005-10-26 15:26 ` Johannes Schindelin
2005-10-26 15:30 ` Randal L. Schwartz
2005-10-26 16:15 ` Jan Harkes
2005-10-26 16:46 ` Johannes Schindelin
2005-10-26 16:55 ` Jan Harkes
2005-10-26 17:03 ` Johannes Schindelin
2005-10-26 17:27 ` Linus Torvalds
2005-10-26 16:11 ` Linus Torvalds
2005-10-26 16:43 ` Johannes Schindelin
2005-10-26 17:22 ` Horst von Brand
2005-10-26 18:50 ` Randal L. Schwartz
2005-10-26 20:08 ` Junio C Hamano [this message]
2005-10-26 20:12 ` Randal L. Schwartz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr7a8ca8j.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=merlyn@stonehenge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).