git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: benoit.person@ensimag.fr
Cc: git@vger.kernel.org, Celestin Matte <celestin.matte@ensimag.fr>,
	Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Subject: Re: [PATCH V2] git-remote-mediawiki: remove hardcoded version number in the test suite
Date: Fri, 14 Jun 2013 11:09:27 -0700	[thread overview]
Message-ID: <7vsj0ko97s.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1371205151-13549-1-git-send-email-benoit.person@ensimag.fr> (benoit person's message of "Fri, 14 Jun 2013 12:19:11 +0200")

benoit.person@ensimag.fr writes:

> From: Benoit Person <benoit.person@ensimag.fr>
>
> Updates the code to make it more easy to switch mediawiki version when
> testing. Before that, the version number was partly hardcoded, partly
> in a var.

This definitely goes in a good direction; you no longer have to
touch random lines in test-gitmw-lib.sh and what you have to edit 
is very much localized.

It seems t/test.config that is tracked is also designed to be
randomly edited to suit user's needs.

The patch does not make things any worse, but I would imagine that a
better longer term structure would be for contrib/mw-to-git/Makefile
to create contrib/mw-to-git/t/test.config by replacing variables in
contrib/mw-to-git/t/test.config-template, so that the user could say

	cd contrib/mw-to-git
        make MW_VERSION_MAJOR=1.20 MW_VERSION_MINOR=0 test

or something like that.

But of course, that is a totally unrelated issue.

Will apply.  Thanks.

      reply	other threads:[~2013-06-14 18:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-14 10:19 [PATCH V2] git-remote-mediawiki: remove hardcoded version number in the test suite benoit.person
2013-06-14 18:09 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsj0ko97s.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=benoit.person@ensimag.fr \
    --cc=celestin.matte@ensimag.fr \
    --cc=git@vger.kernel.org \
    --cc=matthieu.moy@grenoble-inp.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).