From: Junio C Hamano <gitster@pobox.com>
To: Lukas Fleischer <git@cryptocrack.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/3] Add public function read_blob_data_from_index_path()
Date: Sat, 13 Apr 2013 23:55:42 -0700 [thread overview]
Message-ID: <7vsj2t61ox.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vwqs56418.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sat, 13 Apr 2013 22:49:36 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> diff --git a/attr.c b/attr.c
> index a668a63..46bde57 100644
> --- a/attr.c
> +++ b/attr.c
> @@ -387,7 +387,7 @@ static struct attr_stack *read_attr_from_index(const char *path, int macro_ok)
> char *buf, *sp;
> int lineno = 0;
>
> - buf = read_blob_data_from_index_path(path, use_index);
> + buf = read_blob_data_from_index(use_index, path);
This was wrong.
The one I'll push out will have:
buf = read_blob_data_from_index(use_index ? use_index : &the_index, path);
next prev parent reply other threads:[~2013-04-14 6:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 17:26 [PATCH 0/3] Remove ~25 lines of duplicate code Lukas Fleischer
2013-04-12 17:26 ` [PATCH 1/3] Make read_index_data() public Lukas Fleischer
2013-04-12 19:40 ` Jeff King
2013-04-13 8:23 ` Lukas Fleischer
2013-04-12 17:26 ` [PATCH 2/3] Add size parameter to read_index_data() Lukas Fleischer
2013-04-12 17:26 ` [PATCH 3/3] convert.c: Remove duplicate code Lukas Fleischer
2013-04-13 13:28 ` [PATCH v2 1/3] Add public function read_blob_data_from_index_path() Lukas Fleischer
2013-04-13 13:28 ` [PATCH v2 2/3] Add size parameter to read_blob_data_from_index_path() Lukas Fleischer
2013-04-13 13:28 ` [PATCH v2 3/3] convert.c: Remove duplicate code Lukas Fleischer
2013-04-14 5:49 ` [PATCH v2 1/3] Add public function read_blob_data_from_index_path() Junio C Hamano
2013-04-14 6:55 ` Junio C Hamano [this message]
2013-04-14 20:14 ` Lukas Fleischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsj2t61ox.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@cryptocrack.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).