From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Johannes Sixt <j6t@kdbg.org>, Aaron Schrab <aaron@schrab.com>,
Clemens Buchacher <drizzd@aon.at>,
David Michael Barr <b@rr-dav.id.au>,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Subject: Re: [PATCH v3 1/2] run-command: add new check_command helper
Date: Sun, 07 Apr 2013 10:52:13 -0700 [thread overview]
Message-ID: <7vsj322ppu.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1365320706-13539-2-git-send-email-felipe.contreras@gmail.com> (Felipe Contreras's message of "Sun, 7 Apr 2013 01:45:05 -0600")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> - while ((waiting = waitpid(pid, &status, 0)) < 0 && errno == EINTR)
> - ; /* nothing */
> + /* First try the last status from check_command() */
> + if (cmd && cmd->last_status.valid) {
> + status = cmd->last_status.status;
> + waiting = pid;
> + } else {
> + while ((waiting = waitpid(pid, status, 0)) < 0 && errno == EINTR)
> + ; /* nothing */
waitpid(pid, &status, 0), I presume.
next prev parent reply other threads:[~2013-04-07 17:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 7:45 [PATCH v3 0/2] run-command: new check_command helper Felipe Contreras
2013-04-07 7:45 ` [PATCH v3 1/2] run-command: add " Felipe Contreras
2013-04-07 17:47 ` Junio C Hamano
2013-04-07 17:52 ` Junio C Hamano [this message]
2013-04-07 7:45 ` [PATCH v3 2/2] transport-helper: check if remote helper is alive Felipe Contreras
2013-04-07 17:49 ` Junio C Hamano
2013-04-08 0:51 ` Jeff King
2013-04-08 2:03 ` Felipe Contreras
2013-04-08 2:33 ` Jeff King
2013-04-08 14:38 ` Felipe Contreras
2013-04-08 17:43 ` Junio C Hamano
2013-04-08 18:31 ` Felipe Contreras
2013-04-08 18:46 ` Junio C Hamano
2013-04-08 19:08 ` Felipe Contreras
2013-04-08 21:08 ` Junio C Hamano
2013-04-08 21:11 ` Jeff King
2013-04-08 21:21 ` Junio C Hamano
2013-04-08 18:49 ` Jeff King
2013-04-08 19:15 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsj322ppu.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=aaron@schrab.com \
--cc=b@rr-dav.id.au \
--cc=drizzd@aon.at \
--cc=felipe.contreras@gmail.com \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).