From: Junio C Hamano <gitster@pobox.com>
To: Caspar Zhang <caspar@casparzhang.com>
Cc: git@vger.kernel.org, Gris Ge <fge@redhat.com>
Subject: Re: [BUG] incorrect search result returned when using git log with a future date parameter
Date: Wed, 30 Jan 2013 11:57:57 -0800 [thread overview]
Message-ID: <7vsj5ijvei.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <51090466.9070105@casparzhang.com> (Caspar Zhang's message of "Wed, 30 Jan 2013 19:30:46 +0800")
Caspar Zhang <caspar@casparzhang.com> writes:
> .... A date parsing function should parse _all dates with
> correctly format_, despite if it's an old date, or the date in the
> future.
When it is fed 2013-02-12, it is ambiguous and "approxidate" can and
should use whatever heuristics (including rejection of future) to
guess what the user wanted, but 2013-02-13 cannot be interpreted in
any other way, so we should parse it as such.
Patches welcome, as long as the fix does not make things worse for
cases other than you observed.
Thanks.
next prev parent reply other threads:[~2013-01-30 19:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 11:30 [BUG] incorrect search result returned when using git log with a future date parameter Caspar Zhang
2013-01-30 19:57 ` Junio C Hamano [this message]
2013-01-30 22:15 ` Jonathan Nieder
2013-01-30 22:22 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2013-01-30 11:28 Caspar Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsj5ijvei.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=caspar@casparzhang.com \
--cc=fge@redhat.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).