git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jason Holden <jason.k.holden.swdev@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] SubmittingPatches: mention subsystems with dedicated repositories
Date: Tue, 01 Jan 2013 18:14:19 -0800	[thread overview]
Message-ID: <7vsj6k5o1w.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130102015233.GA25288@gmail.com> (Jason Holden's message of "Tue, 1 Jan 2013 20:52:34 -0500")

Jason Holden <jason.k.holden.swdev@gmail.com> writes:

> Any reason to leave out the maintainers email addresses?

Nothing particular, other than that I did not find anywhere in the
file that does not break the flow.

> My only other suggestion for this series might be to augment the file with 
> a patch submittal example(s).  I found the best example to be in 
> git-send-email's man page,...

I'd feel better to avoid copying and pasting.  If send-email has
good examples, shouldn't it be sufficient to refer to them?

> -----------------------------------------------------------
> Example of sending patches for a new feature:
>
> Create the patches:
>  $ git format-patch --cover-letter -M origin/master -o outgoing/
>  $ edit outgoing/0000-*
>
> To send your completed patches for initial consideration:
>  $ git send-email outgoing/* -to git@vger.kernel.org -cc gitster@pobox.com

This is ambiguous; it makes it look as if you are CC'ing the
maintainer, but for the initial round, it is likely that you are
sending it to me only because I have been involved in the area the
patch touches.

> To send your reviewed patches for inclusion:
>  $ git send-email outgoing/* -to gitster@pobox.com -cc git@vger.kernel.org

This is fine, but we would probably want to see it CC'ed to people
who reviewed the initial submission, too.

  reply	other threads:[~2013-01-02  2:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-01 23:24 [PATCH 0/3] Update SubmittingPatches Junio C Hamano
2013-01-01 23:24 ` [PATCH 1/3] SubmittingPatches: who am I and who cares? Junio C Hamano
2013-01-01 23:24 ` [PATCH 2/3] SubmittingPatches: mention subsystems with dedicated repositories Junio C Hamano
2013-01-02  1:52   ` Jason Holden
2013-01-02  2:14     ` Junio C Hamano [this message]
2013-01-02 17:22       ` Junio C Hamano
2013-01-04 20:58         ` [PATCH] SubmittingPatches: Document how to request a patch review tag Jason Holden
2013-01-04 21:47           ` Junio C Hamano
2013-01-06  7:32           ` Michael Haggerty
2013-01-06  9:01             ` Junio C Hamano
2013-01-01 23:24 ` [PATCH 3/3] SubmittingPatches: remove overlong checklist Junio C Hamano
2013-01-02  9:08 ` [PATCH 0/3] Update SubmittingPatches Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsj6k5o1w.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jason.k.holden.swdev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).