From: Junio C Hamano <gitster@pobox.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] rev-list/log: document logic with several limiting options
Date: Tue, 11 Sep 2012 09:22:34 -0700 [thread overview]
Message-ID: <7vsjaoil6d.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <b23f3c547358b79731c7a25d9ac496138e6ab74d.1347374615.git.git@drmicha.warpmail.net> (Michael J. Gruber's message of "Tue, 11 Sep 2012 16:45:53 +0200")
Michael J Gruber <git@drmicha.warpmail.net> writes:
> The current behavior is probably as useful as it is confusing. In any
> case it is going to stay. So, document it.
>
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
> ---
> I would have written a test but don't really know where to stick it in.
> rev-list has many small tests where it doesn't fit.
"git log" would be the more natural place, I would say.
>
> Documentation/rev-list-options.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt
> index 5436eba..9c13df3 100644
> --- a/Documentation/rev-list-options.txt
> +++ b/Documentation/rev-list-options.txt
> @@ -6,6 +6,12 @@ special notations explained in the description, additional commit
> limiting may be applied. Note that they are applied before commit
> ordering and formatting options, such as '--reverse'.
>
> +All occurrences of the same option are ORed: '--grep=foo --grep=bar'
> +limits to commits which match at least one of these conditions.
How would this interact with "--all-match"?
next prev parent reply other threads:[~2012-09-11 16:22 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 14:45 [PATCH] rev-list/log: document logic with several limiting options Michael J Gruber
2012-09-11 16:22 ` Junio C Hamano [this message]
2012-09-12 13:43 ` Michael J Gruber
2012-09-12 17:25 ` Junio C Hamano
2012-09-12 17:26 ` Junio C Hamano
2012-09-13 14:04 ` [PATCHv2 0/6] " Michael J Gruber
2012-09-13 14:04 ` [PATCHv2 1/6] t7810-grep: bring log --grep tests in common form Michael J Gruber
2012-09-13 14:04 ` [PATCHv2 2/6] t7810-grep: test multiple --grep with and without --all-match Michael J Gruber
2012-09-13 14:04 ` [PATCHv2 3/6] t7810-grep: test multiple --author with --all-match Michael J Gruber
2012-09-13 20:47 ` Junio C Hamano
2012-09-13 23:26 ` Junio C Hamano
2012-09-14 8:14 ` Michael J Gruber
2012-09-14 15:55 ` Junio C Hamano
2012-09-13 14:04 ` [PATCHv2 4/6] t7810-grep: test interaction of multiple --grep and --author options Michael J Gruber
2012-09-13 14:04 ` [PATCHv2 5/6] t7810-grep: test --all-match with " Michael J Gruber
2012-09-13 14:04 ` [PATCHv2 6/6] rev-list/log: document logic with several limiting options Michael J Gruber
2012-09-13 22:29 ` Junio C Hamano
2012-09-14 1:19 ` Junio C Hamano
2012-09-14 2:04 ` Junio C Hamano
2012-09-14 9:46 ` [PATCHv3 00/11] " Michael J Gruber
2012-09-14 9:46 ` [PATCHv3 01/11] grep: teach --debug option to dump the parse tree Michael J Gruber
2012-09-14 17:09 ` Junio C Hamano
2012-09-14 9:46 ` [PATCHv3 02/11] log: name --debug-grep option like in the commit message Michael J Gruber
2012-09-14 9:46 ` [PATCHv3 03/11] grep: show --debug output only once Michael J Gruber
2012-09-14 17:11 ` Junio C Hamano
2012-09-14 9:46 ` [PATCHv3 04/11] log --grep/--author: honor --all-match honored for multiple --grep patterns Michael J Gruber
2012-09-14 9:46 ` [PATCHv3 05/11] log: document use of multiple commit limiting options Michael J Gruber
2012-09-14 9:46 ` [PATCHv3 06/11] fixup! " Michael J Gruber
2012-09-14 17:23 ` Junio C Hamano
2012-09-14 9:46 ` [PATCHv3 07/11] t7810-grep: bring log --grep tests in common form Michael J Gruber
2012-09-14 9:46 ` [PATCHv3 08/11] t7810-grep: test multiple --grep with and without --all-match Michael J Gruber
2012-09-14 9:46 ` [PATCHv3 09/11] t7810-grep: test multiple --author with --all-match Michael J Gruber
2012-09-14 17:58 ` Junio C Hamano
2012-09-14 9:46 ` [PATCHv3 10/11] t7810-grep: test interaction of multiple --grep and --author options Michael J Gruber
2012-09-14 9:46 ` [PATCHv3 11/11] t7810-grep: test --all-match with " Michael J Gruber
2012-09-14 18:01 ` Junio C Hamano
2012-09-14 17:25 ` [PATCHv3 00/11] rev-list/log: document logic with several limiting options Junio C Hamano
2012-09-13 20:18 ` [PATCHv2 0/6] " Junio C Hamano
2012-09-13 7:28 ` [PATCH] " Michael J Gruber
2012-09-13 21:21 ` Junio C Hamano
2012-09-14 7:46 ` Michael J Gruber
2012-09-14 7:50 ` Junio C Hamano
2012-09-14 8:21 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsjaoil6d.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).