From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: Robert Luberda <robert@debian.org>, git@vger.kernel.org
Subject: Re: [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id
Date: Tue, 21 Aug 2012 15:35:44 -0700 [thread overview]
Message-ID: <7vsjbfc1q7.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120821214538.GA4879@dcvr.yhbt.net> (Eric Wong's message of "Tue, 21 Aug 2012 21:45:38 +0000")
Eric Wong <normalperson@yhbt.net> writes:
> Robert Luberda <robert@debian.org> wrote:
>> I have been quite a busy recently, so it took me longer that I thought.
>
> No worries, thanks for following up.
>
>> It was quite hard for me to think some sensible option name, and finally
>> have chosen --trim-svn-log (svn.trimsvnlog as config key name). Please
>> let me know if such name is ok for you. If not, I'll try to find a
>> different one (but as I wrote I'm not really good at giving names to
>> options/functions/variables, etc. :()
>
> I think having "svn" in "svn.trimsvnlog" twice is redundant and not ideal.
> Perhaps just --trim-log and svn.trimlog?
Do we ever want to trim "our" log when relaying the Git commits back
to subversion? Having "svn" in "trimsvnlog" makes it clear that the
logs from subversion side is getting trimmed.
> Default behavior should not change, especially not without warning.
Makes sense.
next prev parent reply other threads:[~2012-08-21 22:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 21:23 [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id Robert Luberda
2012-08-01 21:43 ` Eric Wong
2012-08-01 22:27 ` Robert Luberda
2012-08-01 23:01 ` Eric Wong
2012-08-19 21:46 ` Robert Luberda
2012-08-19 21:52 ` [PATCH/RFC] git svn: optionally trim imported log messages Robert Luberda
2012-08-19 23:59 ` Junio C Hamano
2012-08-24 22:38 ` Robert Luberda
2012-08-24 23:38 ` Junio C Hamano
2012-08-21 21:45 ` [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id Eric Wong
2012-08-21 22:35 ` Junio C Hamano [this message]
2012-08-24 23:14 ` Robert Luberda
2012-08-26 0:36 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsjbfc1q7.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=robert@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).