From: Junio C Hamano <gitster@pobox.com>
To: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
Cc: Stefano Lattarini <stefano.lattarini@gmail.com>,
Kacper Kornet <draenog@pld-linux.org>,
git@vger.kernel.org, Lucian Poston <lucian.poston@gmail.com>
Subject: Re: [PATCH] test: skip test with COLUMNS=1 under mksh
Date: Sun, 29 Apr 2012 14:28:34 -0700 [thread overview]
Message-ID: <7vsjfmxm65.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4F9BCFD9.8020005@in.waw.pl> ("Zbigniew Jędrzejewski-Szmek"'s message of "Sat, 28 Apr 2012 13:09:13 +0200")
Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> writes:
> This approach with 'env COLUMNS=1 git ...' looks nicer, and works when
> invoked directly, but doesn't work when run under the test harness,
> because bin-wrappers/git uses !/bin/sh, which resets COLUMNS. So this
> simpler approach doesn't look feasible.
Sigh... That shell seem to be infinitely broken X-<.
next prev parent reply other threads:[~2012-04-29 21:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 2:29 [PATCH v4 1/4] t4052: test --stat output with --graph Lucian Poston
2012-04-18 2:29 ` [PATCH v4 2/4] Adjust stat width calculations to take --graph output into account Lucian Poston
2012-04-18 2:29 ` [PATCH v4 3/4] t4052: Test diff-stat output with minimum columns Lucian Poston
2012-04-18 20:15 ` Junio C Hamano
2012-04-18 21:19 ` Lucian Poston
2012-04-18 21:09 ` Lucian Poston
2012-04-26 22:34 ` Kacper Kornet
2012-04-27 9:25 ` [PATCH] test: skip test with COLUMNS=1 under mksh Zbigniew Jędrzejewski-Szmek
2012-04-27 16:08 ` Junio C Hamano
2012-04-28 11:09 ` Zbigniew Jędrzejewski-Szmek
2012-04-27 16:21 ` Junio C Hamano
2012-04-27 22:35 ` Stefano Lattarini
2012-04-28 11:09 ` Zbigniew Jędrzejewski-Szmek
2012-04-29 21:28 ` Junio C Hamano [this message]
2012-04-18 2:29 ` [PATCH v4 4/4] Prevent graph_width of stat width from falling below min Lucian Poston
2012-04-18 21:12 ` Lucian Poston
2012-04-18 8:47 ` [PATCH v4 1/4] t4052: test --stat output with --graph Zbigniew Jędrzejewski-Szmek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsjfmxm65.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=draenog@pld-linux.org \
--cc=git@vger.kernel.org \
--cc=lucian.poston@gmail.com \
--cc=stefano.lattarini@gmail.com \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).