From: Junio C Hamano <gitster@pobox.com>
To: "W. Trevor King" <wking@drexel.edu>
Cc: Jakub Narebski <jnareb@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v4 2/3] gitweb: refactor If-Modified-Since handling
Date: Mon, 26 Mar 2012 11:39:26 -0700 [thread overview]
Message-ID: <7vsjgvnr4x.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20120326173646.GA6524@odin.tremily.us> (W. Trevor King's message of "Mon, 26 Mar 2012 13:36:46 -0400")
"W. Trevor King" <wking@drexel.edu> writes:
> On Mon, Mar 26, 2012 at 10:12:36AM -0700, Junio C Hamano wrote:
> ...
> Only passing in the epoch. We could reduce computation at the expense
> of complication by passing in both the epoch and a formatted time
> string, but after Jakub's suggestions, I felt like a simpler interface
> was the better approach. I don't feel particularly committed to
> either way, so just tell me which you'd like best ;).
The existing codepath already had the call to parse_date() nearby and that
was the only reason I made the suggestion. The caller in the snapshot
codepath would need to call parse_date() much earlier and it would have to
be conditional to the availability of %co, so the simpler interface would
probably be overall win.
>> Missing " &&" at the end (same in 3/3).
>
> Oops. I wonder why my tests still passed :p. Will fix in v5.
The test will pass if there is no breakage. The offence of missing " &&"
after your "grep 200" is that it will let the test pass even if you did
not have "200" in the output, failing to catch future breakage.
next prev parent reply other threads:[~2012-03-26 18:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 0:23 What's cooking in git.git (Mar 2012, #07; Mon, 19) Junio C Hamano
2012-03-15 7:54 ` [PATCH] Pull gitweb If-Modified-Since handling out into its own function and use for snapshots W. Trevor King
2012-03-20 1:48 ` W. Trevor King
2012-03-20 23:07 ` Junio C Hamano
2012-03-20 11:55 ` Jakub Narebski
2012-03-20 16:40 ` [PATCH v2] " W. Trevor King
2012-03-21 12:11 ` [PATCH v3] Isolate If-Modified-Since handling in gitweb W. Trevor King
2012-03-21 13:19 ` Jakub Narebski
2012-03-21 14:04 ` W. Trevor King
2012-03-21 16:55 ` Jakub Narebski
2012-03-21 17:38 ` W. Trevor King
2012-03-21 19:22 ` Junio C Hamano
2012-03-21 19:55 ` W. Trevor King
2012-03-21 20:04 ` Jakub Narebski
2012-03-21 20:09 ` Junio C Hamano
2012-03-21 20:34 ` W. Trevor King
2012-03-22 13:05 ` Jakub Narebski
2012-03-21 17:21 ` Junio C Hamano
2012-03-22 12:46 ` Jakub Narebski
2012-03-22 17:00 ` Junio C Hamano
2012-03-26 11:09 ` [PATCH v4 0/3] " W. Trevor King
2012-03-26 11:11 ` [PATCH v4 1/3] gitweb: add `status` headers to git_feed() responses W. Trevor King
2012-03-26 11:12 ` [PATCH v4 2/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-26 17:12 ` Junio C Hamano
2012-03-26 11:13 ` [PATCH v4 3/3] gitweb: add If-Modified-Since handling to git_snapshot() W. Trevor King
2012-03-26 19:14 ` [PATCH v5 " W. Trevor King
2012-03-27 22:31 ` Jakub Narebski
2012-03-28 13:58 ` W. Trevor King
2012-03-27 19:24 ` [PATCH v4 0/3] Isolate If-Modified-Since handling in gitweb Jakub Narebski
2012-03-27 19:49 ` W. Trevor King
2012-03-27 19:57 ` Jakub Narebski
2012-03-27 19:55 ` W. Trevor King
2012-03-27 20:18 ` Junio C Hamano
2012-03-26 17:36 ` [PATCH v4 2/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-26 18:39 ` Junio C Hamano [this message]
2012-03-26 19:12 ` [PATCH v5 " W. Trevor King
2012-03-27 22:24 ` Jakub Narebski
2012-03-28 13:51 ` W. Trevor King
2012-03-28 14:13 ` Jakub Narebski
2012-03-28 15:46 ` [PATCH v6 0/3] " wking
2012-03-28 15:46 ` [PATCH v6 1/3] gitweb: add `status` headers to git_feed() responses wking
2012-03-28 15:47 ` [PATCH v6 2/3] gitweb: refactor If-Modified-Since handling wking
2012-03-28 15:47 ` [PATCH v6 3/3] gitweb: add If-Modified-Since handling to git_snapshot() wking
2012-03-28 16:08 ` Jakub Narebski
2012-03-28 15:56 ` [PATCH v6 0/3] gitweb: refactor If-Modified-Since handling W. Trevor King
2012-03-20 23:35 ` Incremental updates to What's cooking Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsjgvnr4x.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=wking@drexel.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).