From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
"Shawn O. Pearce" <spearce@spearce.org>,
Jeff King <peff@peff.net>
Subject: Re: [RFC/PATCH] define the way new representation types are encoded in the pack
Date: Fri, 28 Oct 2011 08:24:15 -0700 [thread overview]
Message-ID: <7vsjmdta00.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <m3wrbp44kr.fsf@localhost.localdomain> (Jakub Narebski's message of "Fri, 28 Oct 2011 06:41:57 -0700 (PDT)")
Jakub Narebski <jnareb@gmail.com> writes:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> When bit 4-6 encodes type 5, the first byte is used this way:
>>
>> - Bit 0-3 denotes the real "extended" representation type. Because types
>> 0-7 can already be encoded without using the extended format, we can
>> offset the type by 8 (i.e. if bit 0-3 says 3, it means representation
>> type 11 = 3 + 8);
>
> Why not use third byte for that instead?
Is it a good enough reason that there is no upside for doing so?
next prev parent reply other threads:[~2011-10-28 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 6:04 [RFC/PATCH] define the way new representation types are encoded in the pack Junio C Hamano
2011-10-28 6:12 ` Junio C Hamano
2011-10-30 5:40 ` Nguyen Thai Ngoc Duy
2011-10-30 7:11 ` Junio C Hamano
2011-10-30 7:13 ` Junio C Hamano
2011-10-30 9:31 ` Nguyen Thai Ngoc Duy
2011-10-28 13:41 ` Jakub Narebski
2011-10-28 15:24 ` Junio C Hamano [this message]
2011-10-28 15:44 ` Shawn Pearce
2011-10-28 22:48 ` Nicolas Pitre
2011-10-28 23:07 ` Shawn Pearce
2011-10-28 23:30 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsjmdta00.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=nico@fluxnic.net \
--cc=peff@peff.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox