From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Sebastian Pipping" <webmaster@hartwork.org>,
"SZEDER Gábor" <szeder@ira.uka.de>,
Matthieu@a-pb-sasl-sd.pobox.com,
"Moy <Matthieu.Moy"@gr.pobox.com
Subject: Re: [PATCH 1.8.0] add: make "add -u" update full tree without pathspec
Date: Sun, 06 Feb 2011 21:58:10 -0800 [thread overview]
Message-ID: <7vsjw0v11p.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1297045643-26697-1-git-send-email-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Mon\, 7 Feb 2011 09\:27\:23 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> When -u was introduced in dfdac5d (git-add -u: match the index with
> working tree., 2007-04-20), "add -u" (without pathspec) added
> everything. Shortly after, 2ed2c22 (git-add -u paths... now works from
> subdirectory, 2007-08-16) broke it while fixing something related.
As long as the command takes pathspecs, it should never be tree-wide.
Making it tree-wide when there is no pathspec is even worse.
If "add -p" does not limit operation to the current directory, probably
that is the inconsistency bug to be fixed.
next prev parent reply other threads:[~2011-02-07 5:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 2:27 [PATCH 1.8.0] add: make "add -u" update full tree without pathspec Nguyễn Thái Ngọc Duy
2011-02-07 5:58 ` Junio C Hamano [this message]
2011-02-07 6:14 ` Nguyen Thai Ngoc Duy
2011-02-07 6:26 ` Miles Bader
2011-02-09 10:58 ` Joshua Juran
2011-02-07 12:09 ` Matthieu Moy
2011-02-27 10:46 ` Junio C Hamano
2011-02-27 11:43 ` Matthieu Moy
2011-02-27 17:04 ` Nguyen Thai Ngoc Duy
2011-02-27 13:35 ` Sverre Rabbelier
2011-02-27 17:01 ` Nguyen Thai Ngoc Duy
2011-02-27 16:52 ` Nguyen Thai Ngoc Duy
2011-02-27 19:39 ` Junio C Hamano
2011-02-28 6:37 ` Nguyen Thai Ngoc Duy
2011-02-28 6:56 ` Junio C Hamano
2011-03-01 11:22 ` Nguyen Thai Ngoc Duy
2011-03-01 13:46 ` Junio C Hamano
2011-03-01 14:15 ` Nguyen Thai Ngoc Duy
2011-03-01 14:53 ` Matthieu Moy
2011-03-01 18:40 ` Junio C Hamano
2011-03-01 18:51 ` Matthieu Moy
2011-03-01 19:36 ` Jakub Narebski
2011-03-01 20:00 ` Jeff King
2011-03-01 20:12 ` Junio C Hamano
2011-03-01 20:25 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsjw0v11p.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc="Moy <Matthieu.Moy"@gr.pobox.com \
--cc=Matthieu@a-pb-sasl-sd.pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=szeder@ira.uka.de \
--cc=webmaster@hartwork.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).