Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Pauli Virtanen <pav@iki.fi>, git@vger.kernel.org
Subject: Re: [PATCH] git-add--interactive: never skip files included in index
Date: Mon, 12 Oct 2009 16:42:14 -0700	[thread overview]
Message-ID: <7vskdo5gdl.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20091012051157.GA23007@coredump.intra.peff.net

Jeff King <peff@peff.net> writes:

> Subject: [PATCH] ls-files: excludes should not impact tracked files
>
> In all parts of git, .gitignore and other exclude files
> impact only how we treat untracked files; they should have
> no effect on files listed in the index.
>
> This behavior was originally implemented very early on in
> 9ff768e, but only for --exclude-from. Later, commit 63d285c
> accidentally caused us to trigger the behavior for
> --exclude-per-directory.
>
> This patch totally ignores excludes for files found in the
> index. This means we are reversing the original intent of
> 9ff768e, while at the same time fixing the accidental
> behavior of 63d285c. This is a good thing, though, as the
> way that 9ff768e behaved does not really make sense with the
> way exclusions are used in modern git.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---

Makes sense; thanks.

> I also still think that Pauli's patch makes sense; there is no point in
> passing --exclude-standard there. It should be a no-op.

Yeah, that is also queued independent from this one.

      reply	other threads:[~2009-10-12 23:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-10 15:51 [PATCH] git-add--interactive: never skip files included in index Pauli Virtanen
2009-10-11 18:52 ` Junio C Hamano
2009-10-11 19:14   ` Jeff King
2009-10-11 22:22     ` Junio C Hamano
2009-10-12  1:40       ` Jeff King
2009-10-12  2:46         ` Junio C Hamano
2009-10-12  5:11           ` Jeff King
2009-10-12 23:42             ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vskdo5gdl.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=pav@iki.fi \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox