From: Junio C Hamano <gitster@pobox.com>
To: Johan Herland <johan@herland.net>
Cc: git@vger.kernel.org, Brandon Casey <casey@nrlssc.navy.mil>,
Brandon Casey <drafnel@gmail.com>
Subject: Re: [PATCH next] t7407: use 'cut' utility rather than bash's substring expansion notation
Date: Thu, 20 Aug 2009 00:34:10 -0700 [thread overview]
Message-ID: <7vskfnq6q5.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <200908200856.30359.johan@herland.net> (Johan Herland's message of "Thu\, 20 Aug 2009 08\:56\:30 +0200")
Johan Herland <johan@herland.net> writes:
>> - $sub1sha1 sub1 (${sub1sha1:0:7})
>> - $sub2sha1 sub2 (${sub1sha1:0:7})
>> + $sub1sha1 sub1 ($(echo $sub1sha1 | cut -c 1-7))
>> + $sub2sha1 sub2 ($(echo $sub1sha1 | cut -c 1-7))
>
> Typo (both in the original, and the patch), should be:
> $sub2sha1 sub2 ($(echo $sub2sha1 | cut -c 1-7))
>
>> $sub3sha1 sub3 (heads/master)
>> EOF
>
> Otherwise:
>
> Acked-by: Johan Herland <johan@herland.net>
Hmm, what does the command use to shorten these object names? It may be
safer and more correct to use "rev-parse --short" in case these object
names were ambigous in their first 7 hexdigits.
next prev parent reply other threads:[~2009-08-20 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 1:24 [PATCH next] t7407: use 'cut' utility rather than bash's substring expansion notation Brandon Casey
2009-08-20 6:56 ` Johan Herland
2009-08-20 7:34 ` Junio C Hamano [this message]
2009-08-20 9:24 ` Johan Herland
2009-08-20 16:59 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskfnq6q5.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=casey@nrlssc.navy.mil \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox