From: Junio C Hamano <gitster@pobox.com>
To: Emmanuel Trillaud <etrillaud@gmail.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [PATCH 4/9] add missing long option to 'git grep' bash competion
Date: Sat, 08 Aug 2009 12:48:27 -0700 [thread overview]
Message-ID: <7vskg2dr3o.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 9f50533b0908080156h23415740lb94cbd9f2c6a165d@mail.gmail.com
Emmanuel Trillaud <etrillaud@gmail.com> writes:
> according to the 'git-grep' man page, the following long options are missing
> from the 'git grep' bash completion :
> --null
> --color
> --no-color
I do not think completion's purpose should be to offer everything
available under the sun, so "according to manpage these are missing" can
never be a good justification for patches in this series.
Does it even make sense to complete --null in an interactive invocation?
next prev parent reply other threads:[~2009-08-08 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-08 8:56 [PATCH 4/9] add missing long option to 'git grep' bash competion Emmanuel Trillaud
2009-08-08 19:48 ` Junio C Hamano [this message]
2009-08-08 20:07 ` Emmanuel Trillaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskg2dr3o.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=etrillaud@gmail.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).