From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 4/9] add missing long option to 'git grep' bash competion Date: Sat, 08 Aug 2009 12:48:27 -0700 Message-ID: <7vskg2dr3o.fsf@alter.siamese.dyndns.org> References: <9f50533b0908080156h23415740lb94cbd9f2c6a165d@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Shawn O. Pearce" , git@vger.kernel.org To: Emmanuel Trillaud X-From: git-owner@vger.kernel.org Sat Aug 08 21:49:10 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1MZruf-0008Pb-LA for gcvg-git-2@gmane.org; Sat, 08 Aug 2009 21:49:10 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753070AbZHHTsw (ORCPT ); Sat, 8 Aug 2009 15:48:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752974AbZHHTsv (ORCPT ); Sat, 8 Aug 2009 15:48:51 -0400 Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:33403 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbZHHTsv (ORCPT ); Sat, 8 Aug 2009 15:48:51 -0400 Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id AE1FC37E6; Sat, 8 Aug 2009 15:48:50 -0400 (EDT) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 81EBF37E5; Sat, 8 Aug 2009 15:48:42 -0400 (EDT) User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-Pobox-Relay-ID: 7EB13118-8454-11DE-ADD2-EAC21EFB4A78-77302942!a-pb-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Emmanuel Trillaud writes: > according to the 'git-grep' man page, the following long options are missing > from the 'git grep' bash completion : > --null > --color > --no-color I do not think completion's purpose should be to offer everything available under the sun, so "according to manpage these are missing" can never be a good justification for patches in this series. Does it even make sense to complete --null in an interactive invocation?