git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Mike Hommey <mh@glandium.org>
Subject: Re: [PATCH 07/18] Some cleanup in get_refs_via_curl()
Date: Sun, 24 May 2009 13:43:42 -0700	[thread overview]
Message-ID: <7vskiuteo1.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20090524221949.4e61f987.rctay89@gmail.com

Tay Ray Chuan <rctay89@gmail.com> writes:

> Signed-off-by: Mike Hommey <mh@glandium.org>
> Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>

The same comment as 06/18 on attribution apllies.

Be specific when you can without going to too verbose.  In this case,
instead of wasting two meaningless words "Some cleanup", you can say:

	Subject: transport.c::get_refs_via_curl(): do not leak refs_url

>  transport.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/transport.c b/transport.c
> index 89d846e..b7c1c39 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -519,6 +519,7 @@ static struct ref *get_refs_via_curl(struct transport *transport, int for_push)
>  		free(ref);
>  	}
>
> +	free(refs_url);
>  	return refs;
>  }
>
> --
> 1.6.3.1

      reply	other threads:[~2009-05-24 21:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-24 14:19 [PATCH 07/18] Some cleanup in get_refs_via_curl() Tay Ray Chuan
2009-05-24 20:43 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vskiuteo1.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=mh@glandium.org \
    --cc=rctay89@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).