git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org, Nanako Shiraishi <nanako3@lavabit.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: Re: [PATCH v3] send-email: add --confirm option and configuration setting
Date: Mon, 02 Mar 2009 22:53:06 -0800	[thread overview]
Message-ID: <7vsklvgkrx.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1236055938-65407-1-git-send-email-jaysoffian@gmail.com> (Jay Soffian's message of "Mon, 2 Mar 2009 23:52:18 -0500")

Jay Soffian <jaysoffian@gmail.com> writes:

> There is a slight fib in message informing the user of the
> sendemail.confirm setting and this is intentional. Setting 'auto'
> differs from leaving sendemail.confirm unset in two ways: 1) 'auto'
> obviously squelches the informational message; 2) 'auto' prompts when
> the Cc list has been expanded even in the presence of a --suppress
> related option, where leaving sendemail.confirm unset does not. This is
> intentional to keep the message simple, and to avoid adding another
> sendemail.confirm value ('auto-except-suppress'?).

I suspect you may get bug reports and refinement patches on top of this to
fix the last issue up, but I think that better should happen once the base
patch is in-tree.

Let's queue this to 'pu' and see how people react. 

Thanks.

  reply	other threads:[~2009-03-03  6:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-01  8:23 [PATCH] send-email: add --confirm option Jay Soffian
2009-03-01  9:03 ` Junio C Hamano
2009-03-01 14:05   ` Jay Soffian
2009-03-01 16:17   ` [PATCH v2] " Jay Soffian
2009-03-01 17:09     ` Paul Gortmaker
2009-03-01 17:49       ` Jay Soffian
2009-03-02  8:24         ` Nanako Shiraishi
2009-03-02  9:01           ` Junio C Hamano
2009-03-02  9:23             ` Nanako Shiraishi
2009-03-02 10:35             ` Felipe Contreras
2009-03-02 12:33           ` Jay Soffian
2009-03-02  7:34     ` Junio C Hamano
2009-03-02 12:35       ` Jay Soffian
2009-03-03  2:47     ` Junio C Hamano
2009-03-03  4:52       ` [PATCH v3] send-email: add --confirm option and configuration setting Jay Soffian
2009-03-03  6:53         ` Junio C Hamano [this message]
2009-03-03 10:11         ` Nanako Shiraishi
2009-03-03 11:54         ` Bert Wesarg
2009-03-03 16:22           ` Jay Soffian
2009-03-03 16:48             ` Junio C Hamano
2009-03-03 18:05               ` Bert Wesarg
2009-03-03 18:18                 ` Jay Soffian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vsklvgkrx.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jaysoffian@gmail.com \
    --cc=nanako3@lavabit.com \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).