From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: layer <layer@known.net>, git@vger.kernel.org
Subject: Re: [PATCH] clone: run post-checkout hook when checking out
Date: Mon, 02 Mar 2009 22:45:09 -0800 [thread overview]
Message-ID: <7vsklvhzpm.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090303053750.GA30201@coredump.intra.peff.net> (Jeff King's message of "Tue, 3 Mar 2009 00:37:51 -0500")
Jeff King <peff@peff.net> writes:
> Junio, I'm not sure what you want to do with this. It is definitely a
> behavior change; we have never respected post-checkout hooks in shell
> git-clone.sh or in the builtin version. However, it seems like an
> omission rather than an intentional behavior, so I consider this a
> bugfix.
I do not mind queueing this to 'pu' and let people fight it out. I hate
the local side hooks that have no reason to be there, and consider that
the existence of the "checkout hook" to be a bug to begin with, but I
really don't care that deeply anymore.
next prev parent reply other threads:[~2009-03-03 6:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-02 22:43 post-checkout hook not run on clone layer
2009-03-03 4:28 ` Jeff King
2009-03-03 5:02 ` layer
2009-03-03 5:10 ` Jeff King
2009-03-03 5:37 ` [PATCH] clone: run post-checkout hook when checking out Jeff King
2009-03-03 6:45 ` Junio C Hamano [this message]
2009-03-03 6:55 ` Jay Soffian
2009-03-03 10:07 ` Nanako Shiraishi
2009-03-03 7:03 ` Jeff King
2009-03-04 5:01 ` layer
2009-03-03 5:04 ` post-checkout hook not run on clone Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsklvhzpm.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=layer@known.net \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).