From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>,
git@vger.kernel.org, Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH] gitweb: fix wrong base URL when non-root DirectoryIndex
Date: Fri, 13 Feb 2009 18:14:36 -0800 [thread overview]
Message-ID: <7vskmh3gtv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200902130945.20601.jnareb@gmail.com> (Jakub Narebski's message of "Fri, 13 Feb 2009 09:45:19 +0100")
Jakub Narebski <jnareb@gmail.com> writes:
>> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
>
> Sounds good. I don't use gitweb as DirectoryIndex myself, but
> Acked-by: Jakub Narebski <jnareb@gmail.com>
>
>> +# Another issue with the script being the DirectoryIndex is that the resulting
>> +# $my_url data is not the full script URL: this is good, because we want
>> +# generated links to keep implying the script name if it wasn't explicitly
>> +# indicated in the URL we're handling, but it means that $my_url cannot be used
>> +# as base URL. Therefore, we have to build the base URL ourselves:
>> +our $base_url = $cgi->url(-base => 1) . $ENV{'SCRIPT_NAME'};
Breaks t9500 with
[Sat Feb 14 02:12:59 2009] gitweb.perl: Use of uninitialized value in concatenation (.) or string at /pub/git/t/../gitweb/gitweb.perl line 45.
Please be more careful when giving an Ack, and more importantly please do
not send a patch that does not even pass the test suite by itself.
next prev parent reply other threads:[~2009-02-14 2:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 21:11 [PATCH] gitweb: fix wrong base URL when non-root DirectoryIndex Giuseppe Bilotta
2009-02-12 22:03 ` Jakub Narebski
2009-02-13 7:36 ` Giuseppe Bilotta
2009-02-13 7:40 ` Giuseppe Bilotta
2009-02-13 8:45 ` Jakub Narebski
2009-02-14 2:14 ` Junio C Hamano [this message]
2009-02-14 2:42 ` Jakub Narebski
2009-02-14 8:52 ` Giuseppe Bilotta
2009-02-14 9:30 ` Junio C Hamano
2009-02-14 10:04 ` [PATCH v3] " Jakub Narebski
2009-02-14 14:29 ` Giuseppe Bilotta
2009-02-15 9:18 ` [PATCHv4] " Giuseppe Bilotta
2009-02-15 19:33 ` [PATCH v3] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskmh3gtv.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
--cc=jnareb@gmail.com \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).