From: Junio C Hamano <gitster@pobox.com>
To: Mike Hommey <mh@glandium.org>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Robin Rosenberg <robin.rosenberg.lists@dewire.com>,
Git ML <git@vger.kernel.org>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: gc considered dangerous
Date: Sun, 08 Feb 2009 23:43:00 -0800 [thread overview]
Message-ID: <7vskmoukcb.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090209065919.GB13257@glandium.org> (Mike Hommey's message of "Mon, 9 Feb 2009 07:59:19 +0100")
Mike Hommey <mh@glandium.org> writes:
> On Sun, Feb 08, 2009 at 12:00:57PM -0800, Junio C Hamano wrote:
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>>
>> > My preliminary guess is that this code in pack-write.c needs to use the
>> > lock file paradigm:
>> >
>> > if (!index_name) {
>> > [...]
>> > } else {
>> > unlink(index_name);
>> > fd = open(index_name, O_CREAT|O_EXCL|O_WRONLY, 0600);
>> > }
>>
>> Whoa. That particular code has been (and is still) correct.
>
> Don't both unlink and open fail in the case the index file is locked in
> Windows ?
Read the rest of the thread and read the code.
The index_file in question is not the file git-repack is telling
pack-write.c to unlink and open.
next prev parent reply other threads:[~2009-02-09 7:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 2:47 gc considered dangerous Robin Rosenberg
2009-02-08 14:34 ` Robin Rosenberg
2009-02-08 14:56 ` Johannes Schindelin
2009-02-08 16:04 ` Robin Rosenberg
2009-02-08 17:18 ` Johannes Schindelin
2009-02-08 18:24 ` Steffen Prohaska
2009-02-08 19:37 ` Robin Rosenberg
2009-02-08 20:00 ` Junio C Hamano
2009-02-08 20:08 ` Robin Rosenberg
2009-02-08 20:10 ` Robin Rosenberg
2009-02-09 6:59 ` Mike Hommey
2009-02-09 7:43 ` Junio C Hamano [this message]
2009-02-08 20:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskmoukcb.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=robin.rosenberg.lists@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).