From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Ray Chuan <rctay89@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] http-push: refactor request url creation
Date: Mon, 26 Jan 2009 20:58:30 -0800 [thread overview]
Message-ID: <7vskn51h1l.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0901261141070.14855@racer> (Johannes Schindelin's message of "Mon, 26 Jan 2009 11:41:30 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> curl strdup's it, so this is safe.
>
> I might have mentioned that things like this _need_ to go into the commit
> message.
Yeah, and let's not forget advice from Daniel Stenberg.
I'm not sure what the oldest possibly libcurl version git can deal
with, but here's a related quote from the curl_easy_setopt man page:
NOTE: before 7.17.0 strings were not copied. Instead the user was
forced keep them available until libcurl no longer needed them.
next prev parent reply other threads:[~2009-01-27 5:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-25 6:08 [PATCH] http-push: refactor request url creation Ray Chuan
2009-01-25 20:35 ` Junio C Hamano
2009-01-26 1:52 ` Ray Chuan
2009-01-26 8:02 ` Daniel Stenberg
2009-01-26 10:41 ` Johannes Schindelin
2009-01-27 4:58 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-01-28 22:19 Tay Ray Chuan
2009-01-28 22:51 ` Junio C Hamano
2009-01-28 23:06 ` Johannes Schindelin
2009-01-29 11:49 ` Tay Ray Chuan
2009-01-30 23:51 Tay Ray Chuan
2009-02-01 0:55 ` Junio C Hamano
2009-02-01 22:45 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskn51h1l.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).