From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] http-push: refactor request url creation Date: Mon, 26 Jan 2009 20:58:30 -0800 Message-ID: <7vskn51h1l.fsf@gitster.siamese.dyndns.org> References: <7vpribdszr.fsf@gitster.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ray Chuan , git@vger.kernel.org To: Johannes Schindelin X-From: git-owner@vger.kernel.org Tue Jan 27 06:00:09 2009 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1LRg3Q-0002y5-7T for gcvg-git-2@gmane.org; Tue, 27 Jan 2009 06:00:04 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751723AbZA0E6l (ORCPT ); Mon, 26 Jan 2009 23:58:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752018AbZA0E6k (ORCPT ); Mon, 26 Jan 2009 23:58:40 -0500 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:58236 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751959AbZA0E6j (ORCPT ); Mon, 26 Jan 2009 23:58:39 -0500 Received: from localhost.localdomain (unknown [127.0.0.1]) by b-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTP id BA61B1D60D; Mon, 26 Jan 2009 23:58:36 -0500 (EST) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by b-sasl-quonix.sasl.smtp.pobox.com (Postfix) with ESMTPSA id DCA891D5BF; Mon, 26 Jan 2009 23:58:32 -0500 (EST) In-Reply-To: (Johannes Schindelin's message of "Mon, 26 Jan 2009 11:41:30 +0100 (CET)") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-Pobox-Relay-ID: 27DEA8EC-EC2F-11DD-AE1D-0372113D384A-77302942!a-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Johannes Schindelin writes: >> curl strdup's it, so this is safe. > > I might have mentioned that things like this _need_ to go into the commit > message. Yeah, and let's not forget advice from Daniel Stenberg. I'm not sure what the oldest possibly libcurl version git can deal with, but here's a related quote from the curl_easy_setopt man page: NOTE: before 7.17.0 strings were not copied. Instead the user was forced keep them available until libcurl no longer needed them.