From: Junio C Hamano <gitster@pobox.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname
Date: Wed, 14 Jan 2009 03:33:43 -0800 [thread overview]
Message-ID: <7vsknm2kbs.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LSU.2.00.0901141148130.16109@fbirervta.pbzchgretzou.qr
Jan Engelhardt <jengelh@medozas.de> writes:
> parent v1.6.1
>
> git-daemon: use getnameinfo to resolve hostname
>
> This is much shorter than inet_ntop'ing, and also translated
> unresolvable addresses into a string.
translated? (I think you meant "translates" but my English is bad, so I
am double checking).
This indeed is much nicer, provided if it is available at least as widely
as inet_ntop() is.
We seem to ship inet_ntop() in compat/; a few questions.
(1) Do we need similar compat/ function for getnameinfo()? I am guessing
that most likely places are the ones that need NO_INET_NTOP and
NO_INET_PTON, and googling seems to indicate old Cygwin and HP-UX
11.00 may be among them.
(2) Do we still use inet_ntop() elsewhere, and if not, can we remove the
compat/ definitions?
next prev parent reply other threads:[~2009-01-14 11:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 10:48 [PATCH 1/3] git-daemon: single-line logs Jan Engelhardt
2009-01-14 10:48 ` [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname Jan Engelhardt
2009-01-14 10:49 ` [PATCH 3/3] git-daemon: vhost support Jan Engelhardt
2009-01-14 11:33 ` Junio C Hamano
2009-01-14 13:15 ` Jan Engelhardt
2009-01-14 11:33 ` Junio C Hamano [this message]
2009-01-14 13:06 ` [PATCH 2/3] git-daemon: use getnameinfo to resolve hostname Jan Engelhardt
2009-01-14 12:25 ` Jeff King
2009-01-14 14:17 ` Adeodato Simó
2009-01-14 14:22 ` Jay Soffian
2009-01-14 19:25 ` [2/3] " Jan Engelhardt
2009-01-14 11:33 ` [PATCH 1/3] git-daemon: single-line logs Junio C Hamano
2009-01-14 13:03 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsknm2kbs.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jengelh@medozas.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).