From: Junio C Hamano <gitster@pobox.com>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: gitster@pobox.com, spearce@spearce.org, dpotapov@gmail.com,
git@vger.kernel.org
Subject: Re: [PATCH] compat/cygwin.c - Use cygwin's stat if core.filemode == true
Date: Sun, 12 Oct 2008 12:35:07 -0700 [thread overview]
Message-ID: <7vskr1fvys.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1223837086-2864-1-git-send-email-mlevedahl@gmail.com> (Mark Levedahl's message of "Sun, 12 Oct 2008 14:44:46 -0400")
Mark Levedahl <mlevedahl@gmail.com> writes:
> Cygwin's POSIX emulation allows use of core.filemode true, unlike native
> Window's implementation of stat / lstat, and Cygwin/git users who have
> configured core.filemode true in various repositories will be very
> unpleasantly surprised to find that git is no longer honoring that option.
> So, this patch forces use of Cygwin's stat functions if core.filemode is
> set true, regardless of any other considerations.
>
> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
> ---
> Updated to use trust_executable_bit as suggested on the list.
Before you do that, can you explain why git_cygwin_config() should
duplicate the setting of that variable instead of using the existing
parser for that variable by calling git_default_config()?
next prev parent reply other threads:[~2008-10-12 19:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-11 18:54 [PATCH] compat/cygwin.c - Use cygwin's stat if core.filemode == true Mark Levedahl
2008-10-11 19:04 ` Mark Levedahl
2008-10-11 21:34 ` Junio C Hamano
2008-10-11 22:56 ` Mark Levedahl
2008-10-12 13:39 ` Dmitry Potapov
2008-10-12 18:44 ` Mark Levedahl
2008-10-12 19:35 ` Junio C Hamano [this message]
2008-10-12 20:23 ` Mark Levedahl
2008-10-12 23:39 ` Junio C Hamano
2008-10-13 4:31 ` Mark Levedahl
2008-10-13 4:33 ` Mark Levedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskr1fvys.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=mlevedahl@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).