From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make reflog query '@{1219188291}' act as '@{2008/08/19 16:24:51}'
Date: Tue, 19 Aug 2008 16:57:46 -0700 [thread overview]
Message-ID: <7vskt0woat.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080819234433.GJ24212@spearce.org> (Shawn O. Pearce's message of "Tue, 19 Aug 2008 16:44:33 -0700")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> The value 1112911993 was chosen for the limit as it is the commit
> timestamp for e83c516331 "Initial revision of "git" ...". Any
> reflogs in existance should contain timestamps dated later than
> the date Linus first stored Git into itself, as reflogs came about
> quite a bit after that.
>
> Additionally a reflog with 1,112,911,993 record entries is also
> simply not valid. Such a reflog would require at least 87 TB to
> store just the old and new SHA-1 values. So our randomly chosen
> upper limit for @{nth} notation is "big enough" that users will
> not run into it by accident.
Hmm, would we want to apply that logic to replace the magic "8-digit" rule
in date.c::match_digit()?
next prev parent reply other threads:[~2008-08-19 23:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 23:44 [PATCH] Make reflog query '@{1219188291}' act as '@{2008/08/19 16:24:51}' Shawn O. Pearce
2008-08-19 23:57 ` Junio C Hamano [this message]
2008-08-20 0:03 ` Shawn O. Pearce
2008-08-20 19:35 ` Alex Riesen
2008-08-20 19:44 ` Shawn O. Pearce
2008-08-20 19:54 ` Alex Riesen
2008-08-20 20:00 ` Shawn O. Pearce
2008-08-20 20:09 ` Alex Riesen
2008-08-20 22:20 ` Junio C Hamano
2008-08-21 15:40 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskt0woat.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).