From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Marcus Griep <marcus@griep.us>,
Git Mailing List <git@vger.kernel.org>,
Jonathan Nieder <jrnieder@uchicago.edu>
Subject: Re: [PATCH v2] bash-completion: Add non-command git help files to bash-completion
Date: Sat, 16 Aug 2008 02:30:37 -0700 [thread overview]
Message-ID: <7vskt5gvcy.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080815180059.GA17399@spearce.org> (Shawn O. Pearce's message of "Fri, 15 Aug 2008 11:00:59 -0700")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> Marcus Griep <marcus@griep.us> wrote:
>> Git allows access to the gitattributes man page via `git help attributes`,
>> but this is not discoverable via the bash-completion mechanism. This
>> patch adds all current non-command man pages to the completion candidate
>> list.
>>
>> Signed-off-by: Marcus Griep <marcus@griep.us>
>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
I'd honor this Ack for 1.6.0 and will apply the patch as-is, but that does
not mean I do not think this is a wrong approach in the longer run.
next prev parent reply other threads:[~2008-08-16 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 16:15 [PATCH] bash-completion: Add non-command git help files to bash-completion Marcus Griep
2008-08-15 17:38 ` Jonathan Nieder
2008-08-15 17:53 ` Marcus Griep
2008-08-15 17:59 ` [PATCH v2] " Marcus Griep
2008-08-15 18:00 ` Shawn O. Pearce
2008-08-16 9:30 ` Junio C Hamano [this message]
2008-08-15 18:21 ` [PATCH] " Junio C Hamano
2008-08-15 18:33 ` Marcus Griep
2008-08-15 18:50 ` Junio C Hamano
2008-08-15 19:03 ` Marcus Griep
2008-08-15 20:32 ` Pieter de Bie
2008-08-15 21:17 ` Marcus Griep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskt5gvcy.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@uchicago.edu \
--cc=marcus@griep.us \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).