From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] fix attribute handling in bare repositories
Date: Sun, 08 Jun 2008 13:46:05 -0700 [thread overview]
Message-ID: <7vskvnirjm.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <484BF7BB.1090802@lsrfire.ath.cx> (René Scharfe's message of "Sun, 08 Jun 2008 17:16:11 +0200")
René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> Nguyen Thai Ngoc Duy schrieb:
>> Hi,
>>
>> Currently attr.c will read .gitattributes on disk no matter there is a
>> real worktree or not. This can lead to strange behavior.
>
> Yes, it probably shouldn't do that. What about this patch?
Hmm. I do not know if it breaks anything, but if you are indeed in a bare
repository, the files the codepaths affected try to read would not exist
anyway, so I am not sure what this would fix, other than changing the
behaviour of check-attr from noticing that it was asked for nonsense and
bail out to not noticing nor saying anything useful.
next prev parent reply other threads:[~2008-06-08 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-07 15:21 git-archive and unwanted .gitattributes Nguyen Thai Ngoc Duy
2008-06-07 15:47 ` Jakub Narebski
2008-06-07 16:19 ` Nguyen Thai Ngoc Duy
2008-06-08 15:24 ` René Scharfe
2008-06-08 15:16 ` [PATCH] fix attribute handling in bare repositories René Scharfe
2008-06-08 20:46 ` Junio C Hamano [this message]
2008-06-08 21:31 ` René Scharfe
2008-06-09 4:24 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vskvnirjm.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).