git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Jean-Baptiste Quenot <jbq@caraldi.com>,
	Petr Baudis <pasky@suse.cz>
Subject: Re: [RFC/PATCH v3] gitweb: Better cutting matched string and its context
Date: Mon, 25 Feb 2008 12:18:54 -0800	[thread overview]
Message-ID: <7vskzghjrl.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200802252107.59366.jnareb@gmail.com> (Jakub Narebski's message of "Mon, 25 Feb 2008 21:07:57 +0100")

Jakub Narebski <jnareb@gmail.com> writes:

> Ooops. Sorry about that. I have forgot to transport context when
> doing copy'n'paste.
> ...
> BTW. the example was subtly wrong: you can search _lines_, like grep,
> you cannot search multiline.

Yeah, the original had:

        For example, if you are looking for "very long ... and how"
        in the first paragraph of message (if it were all on a single
        line), wouldn't you want to see:

and you dropped "if it were all on a single line" part, as you
forgot to transport context when doing copy-n-paste ;-)

> Below there is corrected commit message (rewritten to match code).

Thanks.  Will take a look later; I am at day-job today.

  reply	other threads:[~2008-02-25 20:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 17:37 [PATCH] Do not chop HTML tags in commit search result Jean-Baptiste Quenot
2008-02-13 19:16 ` Jakub Narebski
2008-02-13 19:43 ` Junio C Hamano
2008-02-22 16:33   ` [PATCH] gitweb: Better chopping in commit search results Jakub Narebski
2008-02-22 17:14     ` Junio C Hamano
2008-02-22 17:49       ` Jakub Narebski
2008-02-22 19:14         ` Jakub Narebski
2008-02-23 21:44           ` [RFC/PATCH] gitweb: Option to chop at beginning and in the middle in chop_str Jakub Narebski
2008-02-23 22:04           ` [PATCH] gitweb: Better chopping in commit search results Junio C Hamano
2008-02-23 23:36             ` Jakub Narebski
2008-02-24 13:01           ` [RFC/PATCH v2] gitweb: Option to chop at beginning and in the middle in chop_str Jakub Narebski
2008-02-25  1:46             ` Junio C Hamano
2008-02-25 20:07               ` [RFC/PATCH v3] gitweb: Better cutting matched string and its context Jakub Narebski
2008-02-25 20:18                 ` Junio C Hamano [this message]
2008-02-23  9:27     ` [PATCH] gitweb: Better chopping in commit search results Karl Hasselström
2008-02-23 10:20       ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vskzghjrl.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jbq@caraldi.com \
    --cc=jnareb@gmail.com \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).