git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kristian Høgsberg" <krh@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Rename git-core rpm to just git and rename the meta-pacakge to git-all.
Date: Sat, 16 Feb 2008 00:45:00 -0800	[thread overview]
Message-ID: <7vskztb88j.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1203100163-17509-1-git-send-email-krh@redhat.com> (Kristian Høgsberg's message of "Fri, 15 Feb 2008 13:29:23 -0500")

Kristian Høgsberg <krh@redhat.com> writes:

> ---
>
> So here's change to fix my favorite annoyance with the git rpm
> packaging: don't pull in tla when I say yum install git!  The decision
> to make 'git' a metapackage is to say the least unconventional and
> continues to surprise people (here's today discussion:
> http://marc.info/?t=120309228600004&r=1&w=2).
>
> I know it's late and most people who use the git rpms are used to installing
> git-core by now, but myself and most of my Red Hat co-workers (who should
> know a thing or two about rpm packaging) have been fooled by the 'git'
> rpm that pulls in everything.  There's really no precendence for this, quite
> the opposite: you wouldn't expect yum install gcc to pull in fortran, right?
>
> The patch below only affects people who know that 'git' is a metapackage
> and actually use that to pull in everything (but who does?).  The patch
> renames the 'git-core' rpm to just 'git', but adds a 'Provides: git-core'
> there so people who have trained themselves to say yum install git-core
> wont get burned.

Why all of these good information is below the three-dash lines
and without Sign-off?

The spec file I ship in git.git was written by somebody else for
Linus a long time ago, augmented with patches from others over
time, and I freely admit that I am RPM challenged.  I do not
exactly know what I have been shipping, and I do not personally
manage an RPM based system.  Having no way of testing any
changes myself makes me first go hide whenever I see a patch to
the spec file and then re-approach the patch slowly, prodding
with ten-foot pole.  The only thing that is saving the world
from disaster is that Distro people tend to have and do use
their own spec file, not mine ;-)

So I am more than Ok with a patch like this from somebody whose
RPM skills and common sense I can trust.

I have to wonder where the git-p4 obsoletion went, though.

  parent reply	other threads:[~2008-02-16  8:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15 18:29 [PATCH] Rename git-core rpm to just git and rename the meta-pacakge to git-all Kristian Høgsberg
2008-02-15 19:36 ` Jakub Narebski
2008-02-15 21:08 ` Andreas Ericsson
2008-02-15 21:37   ` Kristian Høgsberg
2008-02-16  8:45 ` Junio C Hamano [this message]
2008-02-17  7:57 ` Junio C Hamano
2008-02-18 14:51   ` Jay Soffian
2008-02-18 16:04     ` Kristian Høgsberg
2008-02-18 18:36       ` Junio C Hamano
2008-02-18 19:00         ` Kristian Høgsberg
2008-02-19  1:25         ` Kristian Høgsberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vskztb88j.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=krh@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).