From: Junio C Hamano <gitster@pobox.com>
To: Jari Aalto <jari.aalto@cante.net>
Cc: git@vger.kernel.org
Subject: Re: Applying patches from gmane can be dangerous.
Date: Thu, 07 Feb 2008 00:21:36 -0800 [thread overview]
Message-ID: <7vsl05p46n.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <ve51w5yb.fsf@blue.sea.net> (Jari Aalto's message of "Thu, 07 Feb 2008 10:01:32 +0200")
Jari Aalto <jari.aalto@cante.net> writes:
> FYI,
>
> Emacs Gnus + news.gmane.org gives access to raw articles with single
> command. Suppose cursor is at thread start "!"
>
> ! R. [ 40: Junio C Hamano ] Applying patches from gmane can be dangerous.
> R. [ 19: Nicolas Pitre ]
>
>
> Pressing "C-u g" will display the unmodified article as seen by mail
> transport. Running git's apply command can be automated pretty easily
> from there.
I do not think Gnus demiming (that C-u g helps us with) is not
an issue.
Have you tried to look at the article in question? Inside your
Gnus + news.gmane.org, try typing this:
j 7 2 6 9 9 <Enter> C-u g
The last two keystrokes are your "C-u g".
And look at the second line in the buffer, that says:
From: Brian Downing <bdowning-oU/tDdhfGLReoWH0uzbU5w@public.gmane.org>
and weep X-<.
Then scroll down to find Signed-off-by: lines that are similarly
mangled, and weep more.
Maybe you run a much newer Gnus, and Lars taught "C-u g" to
unmangle them. After all, gmane and Gnus are both his
creations, so it _is_ possible. But somehow I doubt it.
If there weren't gmane address mangling, a quickest way to apply
a gmane patch to commit is:
C-u g | g i t a m - 3 - s <Enter>
For Gnus uninitiated, it reads: show as raw as opposed
to demimed (C-u g), pipe the article to the shell
command (|) that is "git am -3 -s".
But I usually work in batches, so I first C-o (write to file)
the articles to a separate mbox, review and _edit_ them as
needed before running "git am". And C-o does not suffer from
Gnus demiming, so C-u g is not useful in my workflow.
next prev parent reply other threads:[~2008-02-07 8:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-05 21:10 [PATCH v2] compat: Add simplified merge sort implementation from glibc Brian Downing
[not found] ` <20080205211044.GP26392-oU/tDdhfGLReoWH0uzbU5w@public.gmane.org>
2008-02-05 22:21 ` Johannes Schindelin
[not found] ` <alpine.LSU.1.00.0802052220500.8543-OGWIkrnhIhzN0uC3ymp8PA@public.gmane.org>
2008-02-06 2:47 ` Brian Downing
2008-02-07 4:14 ` Applying patches from gmane can be dangerous Junio C Hamano
2008-02-07 4:29 ` Nicolas Pitre
2008-02-07 9:08 ` Junio C Hamano
2008-02-10 10:51 ` 'next' will be rewound and rebuilt after feature releases Junio C Hamano
2008-02-07 8:01 ` Applying patches from gmane can be dangerous Jari Aalto
2008-02-07 8:21 ` Junio C Hamano [this message]
2008-02-07 9:05 ` Mike Hommey
2008-02-07 12:42 ` Johannes Schindelin
2008-02-07 13:32 ` Brian Downing
2008-02-07 14:50 ` Aidan Van Dyk
2008-02-07 15:03 ` Brian Downing
2008-02-07 16:10 ` Johannes Schindelin
2008-02-11 21:16 ` Johannes Schindelin
2008-02-07 14:10 ` Frank Lichtenheld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vsl05p46n.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jari.aalto@cante.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).